-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for when remote actor username changes #30361
base: main
Are you sure you want to change the base?
Add integration test for when remote actor username changes #30361
Conversation
Hi! Thank you for your PR! At a glance, the PR looks ok, but I will do a full review later. It's still marked as a draft, so is there something in particular you want feedback on? |
@ClearlyClaire Thanks for taking a look, it's much appreciated. I've added a few more tests for this case, so it's ready for review now. |
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
….com/angusmcleod/mastodon into add_username_change_integration_test
@ClearlyClaire Thanks for the feedback. This is what I've done:
|
I think we should do something like this eventually, but this is a much more complex endeavour. Indeed, we enforce uniqueness of |
@ClearlyClaire Ensuring username uniqueness is something the remote domain has responsibility for in this case. We can protect against that within the context of Update Actor: angusmcleod@138fee1 |
See further https://socialhub.activitypub.rocks/t/changeable-usernames/830/13?u=angus